txnbuild: adds a 5 minute grace period to ReadChallengeTx MinTime constraint #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
force-pushed
the
txnbuild-add-grace-period-to-challenge-reader
branch
2 times, most recently
from
c5be599
to
4de8287
Compare
|
I had originally created my feature branch on |
|
@ire-and-curses I'm not sure who should review this so feel free to add someone and remove yourself 👍 |
leighmcculloch
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
I think this is good. 👏🏻 We could also make it configurable, but there's no rush to do that now and we can always expose the config later if needed. There's value in making this configurable in SDKs that are used with clients and servers, but less so with servers.
|
@JakeUrban This change is not breaking and you could have it target |
ire-and-curses
approved these changes
Sep 15, 2021
JakeUrban
force-pushed
the
txnbuild-add-grace-period-to-challenge-reader
branch
from
bfd1043
to
5b2b40b
Compare
|
I force pushed to rebase on master, no changes to the code though. |
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Adds a 5 minute grace period to
ReadChallengeTx'sTransaction.Timebounds().MinTimeconstraint to account for clock drift between the client and server.Why
The JS SDK recently merged a similar change (commit), which is now requested for the Go SDK (issue).
Known limitations
N/A